-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub Actions CI #24
Conversation
branches: | ||
- main | ||
schedule: | ||
- cron: "0 21 * * 6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to run this on a cron and burn up CI minutes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geoffharcourt for open source projects GitHub is free. And we can and we should do it.
And in this case 0 21 * * 6
mean at 21:00 on each Saturday.
. Sounds good. One per week run CI to check that everything still works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think we should address whether or not we want a cron running unattended given how little activity there is on the repo in genearl.
List of changes:
master
tomain
Note: this repo has
master
andmain
branches. Looks like, travis usesmaster
branch and should be updated. Also,master
has commits that missed inmain
. So, let's merge master in main and remove it (master).